Bug 2011209 - Fix ALPN field#32
Closed
sbelondr wants to merge 1 commit into
Closed
Conversation
Contributor
|
(Automated Close) Please do not file pull requests here, see https://firefox-source-docs.mozilla.org/contributing/how_to_submit_a_patch.html |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bugzilla : https://bugzilla.mozilla.org/show_bug.cgi?id=2011209
In accordance with RFC 8833, I therefore propose adding a condition so that when the request is a WebRTC request, we set
webrtc,c-webrtcinstead ofhttp/1.1in the fileTlsHandshaker.cpp, in theSetupNPNListfunction.I haven't found any other solution than the one presented in this fix (namely, retrieving the Upgrade value, as this is the only place I found an indication that we are indeed using WebRTC).
I am open to a better solution if one exists.